Skip to content

Conversation

@Shresth79
Copy link
Contributor

What was wrong?

There was a typo in the class name PersistantSocket in web3/providers/ipc.py. The correct spelling should be PersistentSocket (with an 'e' instead of 'a').

How was it fixed?

Fixed the typo by renaming the class from PersistantSocket to PersistentSocket throughout the file.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo
Copy link
Collaborator

fselmo commented May 26, 2025

This is a breaking change and this provider has been deprecated and will be removed. I'm going to close this.

@fselmo fselmo closed this May 26, 2025
@fselmo
Copy link
Collaborator

fselmo commented May 26, 2025

Actually, I apologize on both of my comments and will re-open 😅.

I was under the impression the PersistantSocket was for the old WebSocket provider (now, LegacyWebSocketProvider). I don't think we changed this because it seems like a breaking change but it actually sets the socket on a private, underscored _socket which technically means it can and should be corrected - as this is not a public API.

I'm going to let others get eyes on this to make sure I'm not missing anything but I think this is a fine change to make, and I believe it to be a non-breaking change. Do you want to add a newsfragment for this? If not we can. And thanks for the PR!

@fselmo
Copy link
Collaborator

fselmo commented Jun 5, 2025

@kclowes If you're good with this as non-breaking I can add a newsfragment and merge 👀

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM!

@fselmo
Copy link
Collaborator

fselmo commented Jun 5, 2025

Thanks @Shresth79 👍🏼

@fselmo fselmo merged commit 0daa470 into ethereum:main Jun 5, 2025
1 of 85 checks passed
@Shresth79 Shresth79 deleted the typos branch July 21, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants