bugfix: Fix batching for AutoProvider #3712
Merged
+56
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
commented
May 29, 2025
|
|
||
|
|
||
| def load_provider_from_environment() -> BaseProvider: | ||
| def load_provider_from_environment() -> Optional[JSONBaseProvider]: |
Collaborator
Author
There was a problem hiding this comment.
This narrows scope by a small margin, but I'd argue it's a bugfix. Thoughts here? Batching requires JSONBaseProvider. All of web3 does at the moment, for that matter.
Collaborator
Author
|
cc: @antazoey |
- We can't set the provider, we must let `AutoProvider` decide when it makes proxy calls using the "active" provider. - For the reason above, we need to implement a proxy batch request so that it can instead pull the active provider and make the batch request using it. - Make sure current tests fail with the old implementation and pass with the new one. closes ethereum#3711
fselmo
force-pushed
the
bugfix-auto-provider
branch
from
ae360ca to
4e7bbe7
Compare
kclowes
approved these changes
Jun 4, 2025
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
LGTM! Nice test updates!
|
|
||
|
|
||
| def load_provider_from_environment() -> BaseProvider: | ||
| def load_provider_from_environment() -> Optional[JSONBaseProvider]: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #3711
How was it fixed?
We can't set the provider, we must let
AutoProviderdecide when it makes proxy calls using the "active" provider.For the reason above, we need to implement a proxy batch request so that it can instead pull the active provider and make the batch request using it.
Make sure current tests fail with the old implementation and pass with the new one.
Todo:
Cute Animal Picture