yash/refactor/deprecated_vars

[0xpanicError]

Note

Medium Risk
UUPS proxy storage layout must preserve slot order—incorrect gap sizing would corrupt live state on upgrade; removing transferAccumulatedRevenue is a breaking API change for any caller still using it.

Overview
This PR standardizes upgradeable contract layout across many core src contracts by replacing scattered DEPRECATED_* state variables with explicit __gap_* storage reservations, and grouping declarations under consistent section headers (state, immutables, constants, events, errors, constructor, state-changing functions).

AuctionManager drops the legacy protocol-revenue path: transferAccumulatedRevenue, related state (accumulatedRevenue, thresholds), and IProtocolRevenueManager usage are removed; IAuctionManager no longer exposes that function.

EtherFiRestaker moves etherFiRedemptionManager to an immutable (constructor-set) and removes deprecated EigenLayer withdrawal-root storage in favor of gaps.

WithdrawRequestNFT promotes BASIS_POINT_SCALE / SHARE_UNIT from private to public constants (same values).

No intentional changes to live deposit/withdraw/oracle logic beyond storage layout and the removed auction revenue sweep.

^{Reviewed by Cursor Bugbot for commit 890fc00. Bugbot is set up for automated code reviews on this repo. Configure here.}

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 8450277. Configure here.}