yash/fix/remove-acceptable-share-rate

[0xpanicError]

Note

High Risk
Changes withdrawal finalize and claim payout math by allowing any liquidity-pool share rate at snapshot and on legacy live-rate fallback, with no on-chain circuit breaker.

Overview
WithdrawRequestNFT no longer enforces configurable min/max acceptable share rates. The constructor drops the two rate immutables and their validation; finalizeRequests always snapshots liquidityPool.amountPerShareCeil() without a bounds check; and the legacy-claim path in _getClaimableAmount uses the live rate with no min/max guard. Related errors (InvalidShareRate, InvalidLiveRate, etc.) are removed.

All upgrade scripts, fork tests, integration tests, and WithdrawRequestNFT test helpers are updated to deploy the shorter constructor. Invariant coverage that asserted frozen rates stayed within [min, max] is deleted or simplified accordingly.

^{Reviewed by Cursor Bugbot for commit aedf156. Bugbot is set up for automated code reviews on this repo. Configure here.}

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 92457d3. Configure here.}