yash/fix/deprecate-oz-ownable#460
Merged
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
pankajjagtapp
approved these changes
Jun 4, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 39d552c. Configure here.
pankajjagtapp
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
High Risk
Wide UUPS proxy storage-layout and access-control migration across critical protocol contracts; mistakes could brick upgrades or weaken who can upgrade/seize/admin-call.
Overview
This PR removes active OpenZeppelin
OwnableUpgradeableusage across core protocol proxies in favor ofRoleRegistry-based access control, while keeping the old Ownable storage layout via a newDeprecatedOZOwnableplaceholder (_owner+ gap, noowner()/transferOwnershipAPI).Contract changes: Many upgradeable contracts (
EETH,LiquidityPool,WeETH, oracle/admin, staking, deposits, rewards, withdrawals, etc.) swapOwnableUpgradeableforDeprecatedOZOwnable, drop__Ownable_init()from initializers, and stop relying on per-contract owners for admin paths already gated byRolesLibrary.WeETHWithdrawAdapter.initializeno longer calls_transferOwnership.WithdrawRequestNFTinvalid-request transfers now requireonlyUpgradeTimelockon the registry instead ofowner().Scripts: Deploy/verify steps that assumed timelock
owner()on adapters/distributors are removed or commented in favor of registry-only governance.Tests: Widespread updates from
contract.owner()toroleRegistryInstance.owner(), adjusted timelock tests targetingRoleRegistry(Ownable2Step), and new revert expectations for invalid NFT transfers.Reviewed by Cursor Bugbot for commit b454250. Bugbot is set up for automated code reviews on this repo. Configure here.