-
Notifications
You must be signed in to change notification settings - Fork 16
Docs for Etherlink 6.0 #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
| If you pass `latest` instead of `pending`, the sequencer waits until the transaction is in a block to send the confirmation. | ||
| Etherlink supports this `pending` value only on the `eth_sendRawTransactionSync` method, not on any other methods. | ||
|
|
||
| The sequencer returns information about the transaction, such as its gas price and gas cost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sam here I think could be interesting to mention we return a receipt.
Side note, returning this format and using this name for the endpoint isn't out of my mind we follow a draft EIP on ethereum : https://eips.ethereum.org/EIPS/eip-7966 (but we added the optional block parameter to fill our needs). Might be interesting to mention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. How's this? d29fae4
When the sequencer executes the transaction and intends to put it in the next block, the sequencer returns a receipt for the transaction that includes information such as its gas price and gas cost. This receipt matches the specification for the
eth_getTransactionReceiptendpoint except that theblockHashfield is always0x000...because the block has not been created yet. TheblockNumberfield provides the correct level for the block that the transaction will be in. You can take this response as a confirmation that the sequencer will put the transaction in the next block.
| const web3Instance = new Web3(new Web3.providers.WebsocketProvider('ws://127.0.0.1:8545/ws')); | ||
| // Subscribe to new instant confirmations | ||
| const newConfirmationsSubscription = await web3Instance.eth.subscribe('NewIncludedTransactions'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tez_NewIncludedTransactions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to tez_newIncludedTransactions -- is that capitalization correct?
Co-authored-by: AurelienFT <32803821+AurelienFT@users.noreply.github.com>
Co-authored-by: NicNomadic <148877430+NicNomadic@users.noreply.github.com>
ebadda8 to
139da2f
Compare
3f5b778 to
c15675f
Compare
skenaja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
NicNomadic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docs for proposed kernel 6.0.
eth_sendRawTransactionSyncand two new websocket event streams but they may not be enabled at the time this kernel update goes liveInfo about actually using instant confirmations moved to #396 for when this is enabled and usable.