chore(reserve): comments and rewording and final migration check#4795
chore(reserve): comments and rewording and final migration check#4795
Conversation
istae
changed the title
istae
force-pushed
the
reserve-comments
branch
from
3a9503f to
1742597
Compare
istae
changed the title
pkg/storer/migration/step_06.go
Outdated
| batchRadiusCnt, err := st.IndexStore().Count(&reserve.BatchRadiusItem{}) | ||
| if err != nil { | ||
| return 0, 0, err | ||
| } | ||
|
|
||
| chunkBinCnt, err := st.IndexStore().Count(&reserve.ChunkBinItem{}) | ||
| if err != nil { | ||
| return 0, 0, err | ||
| } | ||
|
|
||
| if batchRadiusCnt != chunkBinCnt { | ||
| return 0, 0, fmt.Errorf("index counts do not match, %d vs %d", batchRadiusCnt, chunkBinCnt) | ||
| } |
There was a problem hiding this comment.
This should be before the migration starts.
Then at the end, we compare that seenCnt == doneCnt == batchRadiusCnt == chunkBinCnt
|
So, if I've already migrated my sepolia testnet nodes without making a backup of the pre-2.2.0 database, should I |
We don't think that the issue is with the migration logic. So if your node completed the migration fine, then at this point, you do not need to do anything. |
Thank you. When the team is ready, possibly after the next RC comes out correcting whatever is going on, I can load a new version of the OSM map into the sepolia testnet which should definitely stress the new chunk timestamp re-use/update logic. |
4 participants
Checklist
Description
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):