chore: extra checks in step 6 migration and small changes to transaction op steps#4803
Merged
chore: extra checks in step 6 migration and small changes to transaction op steps#4803
Conversation
istae
changed the title
istae
force-pushed
the
step6-extracheck
branch
from
276458d to
65e9487
Compare
martinconic
approved these changes
Sep 8, 2024
acha-bill
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Added an extra check at the end of the migration.
Added DeleteWithStamp to stampIndex store.
Made sure Deletes are added to the transaction before the store to avoid any accidental overwrites of batch operations.
Also, no overwrite error should be returned if the
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):