fix: reset reserve only when neighborhood hopping#4807
Merged
Conversation
acha-bill
approved these changes
Sep 10, 2024
martinconic
approved these changes
Sep 10, 2024
nugaon
reviewed
Sep 10, 2024
Member
nugaon
left a comment
nugaon
left a comment
There was a problem hiding this comment.
I thought it keeps the pinned chunks alive somehow, or will that be implemented in a different PR?
Comment on lines
+521
to
+524
| size := r.Size() | ||
|
|
||
| bRitems := make([]*BatchRadiusItem, 0, size) |
Member
There was a problem hiding this comment.
I don't completely get why the capacity equals to the reserve size, it may be better to use any higher value than this since a half of the reserve contains 2 million items.
Contributor
Author
There was a problem hiding this comment.
The size here is the actual number of chunks in the reserve. So the capacity of the slice is exactly the same as the number of entries..
Member
There was a problem hiding this comment.
nice!
is append better than just make with the length of r.Size() and assign by indices?
istae
force-pushed
the
reset-reserve
branch
from
a3a319d to
2358e19
Compare
nugaon
approved these changes
Sep 11, 2024
martinconic
approved these changes
Sep 11, 2024
acha-bill
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
also renamed "namespace" in chunkstamp and stampindex to "scope"
also cleaned up some unnecessary index store funcs
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):