refactor: use ShuffledFullNodeClients #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: bump golangci-lint to v2 * chore: bump golang to 1.25.1 * chore: gofumpt
gacevicljubisa
merged commit b5a6880
into
refactor/separate-smoke-load-checks
3 checks passed
gacevicljubisa
added a commit
that referenced
this pull request
Oct 5, 2025
* refactor(load): separate load check in a new package * refactor(smoke): clean up smoke package * refactor(load): remove whitespace * refactor(load): improve logging and restore old comments * refactor(load, smoke): unify NewMetrics function for smoke and load checks * refactor(smoke): improve client selection logic for smoke checks by using ShuffledFullNodeClients * refactor(load): improve client selection logic for load checks by using ShuffledFullNodeClient * refactor: use ShuffledFullNodeClients (#528) * refactor: use ShuffledFullNodeClients * fix(client): add NodeGroup option to ClientOptions * refactor(cluster): remove unused Next method from ClientList * fix(load): fix NewDefaultOptions * fix: add whitespace for linter * check-smoke: add node name label to metrics (#529) * chore: bump golangci-lint to v2 and golang to v1.25.1 (#508) * chore: bump golangci-lint to v2 * chore: bump golang to 1.25.1 * chore: gofumpt * fix: merge from master * fix: split load and smoke metrics --------- Co-authored-by: akrem-chabchoub <chabchoub.akrem@gmail.com> Co-authored-by: Not Darko <93942788+darkobas2@users.noreply.github.com> * fix: improve log msgs for smoke check * fix: merge from master --------- Co-authored-by: Ljubiša Gačević <35105035+gacevicljubisa@users.noreply.github.com> Co-authored-by: Not Darko <93942788+darkobas2@users.noreply.github.com> Co-authored-by: Ljubisa Gacevic <ljubisa.rs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.