fix(beekeeper): wire backoffLimit into CronJob job template spec#233
Merged
Conversation
darkobas2
approved these changes
May 14, 2026
Contributor
darkobas2
left a comment
darkobas2
left a comment
There was a problem hiding this comment.
Clean, minimal bug fix. LGTM.
The chart's values.yaml has been declaring backoffLimit: 0 but the cronjob template wasn't reading it — so K8s used its default of 6 on every failed Job, and any override in helm values was silently ignored. This wires it through correctly. Version bump is right.
Two small nits (non-blocking):
- PR body is empty — a one-line description ("fix: render
backoffLimitfrom values into CronJob jobTemplate (was previously ignored)") would help downstream consumers reading the commit history later. - If the chart maintains a CHANGELOG, worth an entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.