Skip to content

fix: generate qr from a publicly available url#752

Merged
slapec93 merged 2 commits into
masterfrom
fix/use-gateway-url-for-generating-qr-code
Jun 4, 2026
Merged

fix: generate qr from a publicly available url#752
slapec93 merged 2 commits into
masterfrom
fix/use-gateway-url-for-generating-qr-code

Conversation

@slapec93
Copy link
Copy Markdown
Collaborator

@slapec93 slapec93 commented Jun 4, 2026

No description provided.

@slapec93 slapec93 linked an issue Jun 4, 2026 that may be closed by this pull request
@slapec93 slapec93 requested a review from Cafe137 June 4, 2026 07:44
Copy link
Copy Markdown
Collaborator

@Cafe137 Cafe137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that confirms that the QR function was called with a api.gateway.ethswarm.org/bzz/[0-9a-f]{64} given that the upload was local

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

File Coverage Now Coverage Before Delta% Rating
Total 2638 / 3221 2630 / 3213 0.05 🟢
application.ts 0 / 2 0 / 2 0.00
config.ts 33 / 34 33 / 34 0.00
curl.ts 24 / 24 24 / 24 0.00
index.ts 0 / 16 0 / 16 0.00
printer.ts 3 / 7 3 / 7 0.00
command/addresses.ts 32 / 37 32 / 37 0.00
command/download.ts 32 / 39 32 / 39 0.00
command/hash.ts 8 / 10 8 / 10 0.00
command/quickstart.ts 35 / 38 35 / 38 0.00
command/status.ts 82 / 82 82 / 82 0.00
command/upload.ts 214 / 274 213 / 273 0.08 🟢
command/access/access-command.ts 2 / 2 2 / 2 0.00
command/access/grant.ts 31 / 31 31 / 31 0.00
command/access/history.ts 28 / 31 28 / 31 0.00
command/access/index.ts 10 / 10 10 / 10 0.00
command/access/init.ts 27 / 27 27 / 27 0.00
command/access/list.ts 15 / 15 15 / 15 0.00
command/access/revoke.ts 31 / 31 31 / 31 0.00
command/access/show.ts 23 / 23 23 / 23 0.00
command/cheque/cashout.ts 30 / 32 30 / 32 0.00
command/cheque/cheque-command.ts 21 / 25 21 / 25 0.00
command/cheque/deposit.ts 16 / 16 16 / 16 0.00
command/cheque/index.ts 9 / 9 9 / 9 0.00
command/cheque/list.ts 13 / 13 13 / 13 0.00
command/cheque/withdraw-all.ts 6 / 15 6 / 15 0.00
command/cheque/withdraw.ts 16 / 16 16 / 16 0.00
command/feed/feed-command.ts 55 / 55 54 / 54 0.00
command/feed/index.ts 7 / 7 7 / 7 0.00
command/feed/print.ts 26 / 80 26 / 80 0.00
command/feed/update.ts 14 / 15 14 / 15 0.00
command/feed/upload.ts 26 / 28 26 / 28 0.00
command/grantee/create.ts 20 / 20 20 / 20 0.00
command/grantee/get.ts 11 / 11 11 / 11 0.00
command/grantee/grantee-command.ts 5 / 5 5 / 5 0.00
command/grantee/index.ts 7 / 7 7 / 7 0.00
command/grantee/patch.ts 21 / 21 21 / 21 0.00
command/history/disable.ts 18 / 18 18 / 18 0.00
command/history/enable.ts 15 / 15 15 / 15 0.00
command/history/history-command.ts 2 / 2 2 / 2 0.00
command/history/index.ts 9 / 9 9 / 9 0.00
command/history/list.ts 17 / 17 17 / 17 0.00
command/history/show.ts 26 / 28 26 / 28 0.00
command/history/status.ts 16 / 16 16 / 16 0.00
command/identity/create.ts 36 / 41 36 / 41 0.00
command/identity/export.ts 20 / 22 20 / 22 0.00
command/identity/identity-command.ts 21 / 27 21 / 27 0.00
command/identity/import.ts 50 / 63 50 / 63 0.00
command/identity/index.ts 11 / 11 11 / 11 0.00
command/identity/list.ts 21 / 21 21 / 21 0.00
command/identity/remove.ts 15 / 21 15 / 21 0.00
command/identity/rename.ts 16 / 16 16 / 16 0.00
command/identity/show.ts 27 / 33 27 / 33 0.00
command/manifest/add.ts 38 / 39 38 / 39 0.00
command/manifest/create.ts 16 / 17 16 / 17 0.00
command/manifest/download.ts 52 / 54 52 / 54 0.00
command/manifest/index.ts 11 / 11 11 / 11 0.00
command/manifest/list.ts 40 / 42 40 / 42 0.00
command/manifest/merge.ts 24 / 25 24 / 25 0.00
command/manifest/remove.ts 26 / 29 26 / 29 0.00
command/manifest/sync.ts 46 / 50 46 / 50 0.00
command/pinning/index.ts 9 / 9 9 / 9 0.00
command/pinning/list.ts 14 / 14 14 / 14 0.00
command/pinning/pin.ts 10 / 11 10 / 11 0.00
command/pinning/pinning-command.ts 5 / 8 5 / 8 0.00
command/pinning/reupload-all.ts 21 / 23 21 / 23 0.00
command/pinning/reupload.ts 9 / 17 9 / 17 0.00
command/pinning/unpin.ts 11 / 11 11 / 11 0.00
command/pss/index.ts 7 / 7 7 / 7 0.00
command/pss/pss-command.ts 8 / 8 8 / 8 0.00
command/pss/receive.ts 18 / 24 18 / 24 0.00
command/pss/send.ts 29 / 34 29 / 34 0.00
command/pss/subscribe.ts 8 / 18 8 / 18 0.00
command/root-command/command-config.ts 35 / 41 35 / 41 0.00
command/root-command/command-log.ts 60 / 78 60 / 78 0.00
command/root-command/index.ts 49 / 53 49 / 53 0.00
command/root-command/printer.ts 9 / 9 9 / 9 0.00
command/stake/deposit.ts 30 / 45 30 / 45 0.00
command/stake/index.ts 8 / 8 8 / 8 0.00
command/stake/recover.ts 10 / 22 10 / 22 0.00
command/stake/status.ts 11 / 11 11 / 11 0.00
command/stake/withdraw.ts 7 / 25 7 / 25 0.00
command/stamp/buy.ts 50 / 64 50 / 64 0.00
command/stamp/create.ts 18 / 72 18 / 72 0.00
command/stamp/dilute.ts 12 / 27 12 / 27 0.00
command/stamp/extend.ts 10 / 51 10 / 51 0.00
command/stamp/index.ts 11 / 11 11 / 11 0.00
command/stamp/list.ts 29 / 31 29 / 31 0.00
command/stamp/show.ts 13 / 14 13 / 14 0.00
command/stamp/stamp-command.ts 3 / 7 3 / 7 0.00
command/stamp/topup.ts 11 / 23 11 / 23 0.00
command/utility/cid.ts 8 / 13 8 / 13 0.00
command/utility/create-batch.ts 35 / 38 35 / 38 0.00
command/utility/index.ts 14 / 22 14 / 22 0.00
command/utility/lock.ts 7 / 11 7 / 11 0.00
command/utility/rchash.ts 27 / 27 27 / 27 0.00
command/utility/redeem.ts 43 / 51 43 / 51 0.00
command/utility/unlock.ts 7 / 12 7 / 12 0.00
command/wallet/index.ts 7 / 7 7 / 7 0.00
command/wallet/status.ts 11 / 11 11 / 11 0.00
command/wallet/withdraw-bzz.ts 19 / 21 19 / 21 0.00
command/wallet/withdraw-dai.ts 19 / 21 19 / 21 0.00
service/version_checker.ts 25 / 29 25 / 29 0.00
service/access/index.ts 29 / 31 29 / 31 0.00
service/access/types/history-event.ts 5 / 5 5 / 5 0.00
service/history/index.ts 19 / 21 19 / 21 0.00
service/identity/index.ts 32 / 36 32 / 36 0.00
service/identity/types/identity.ts 4 / 4 4 / 4 0.00
service/identity/types/index.ts 1 / 1 1 / 1 0.00
service/stamp/index.ts 30 / 32 30 / 32 0.00
utils/bzz-address.ts 24 / 30 24 / 30 0.00
utils/chainsync.ts 4 / 4 4 / 4 0.00
utils/contracts.ts 6 / 6 6 / 6 0.00
utils/error.ts 39 / 44 39 / 44 0.00
utils/hex.ts 10 / 14 10 / 14 0.00
utils/index.ts 65 / 83 65 / 83 0.00
utils/message.ts 3 / 12 3 / 12 0.00
utils/mime.ts 5 / 5 5 / 5 0.00
utils/option.ts 5 / 5 5 / 5 0.00
utils/qr.ts 5 / 5 5 / 5 0.00
utils/rpc.ts 43 / 50 43 / 50 0.00
utils/spinner.ts 15 / 15 15 / 15 0.00
utils/text.ts 26 / 27 26 / 27 0.00
utils/url.ts 6 / 6 0 / 0 100.00 🟢
utils/validate.ts 9 / 11 9 / 11 0.00

@slapec93 slapec93 requested a review from Cafe137 June 4, 2026 10:49
@slapec93 slapec93 merged commit 704e7e4 into master Jun 4, 2026
4 checks passed
@slapec93 slapec93 deleted the fix/use-gateway-url-for-generating-qr-code branch June 4, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use gateway URL for generating QR code

2 participants