Skip to content

Replaced Sokol with Chiado#131

Merged
kaushalrajbacancy merged 3 commits intomasterfrom
feature/pro-1059-decommission-sokol-and-add-support-for-a
Apr 18, 2023
Merged

Replaced Sokol with Chiado#131
kaushalrajbacancy merged 3 commits intomasterfrom
feature/pro-1059-decommission-sokol-and-add-support-for-a

Conversation

@kaushalrajbacancy
Copy link
Copy Markdown
Contributor

@kaushalrajbacancy kaushalrajbacancy commented Apr 17, 2023

  • Replaced the configuration of Sokol with Chiado

Description

  • As we are not using Sokol. So, we have added Chiado instead

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@kaushalrajbacancy
Copy link
Copy Markdown
Contributor Author

kaushalrajbacancy commented Apr 17, 2023

@marie-fourier @lbw33 @vignesha22 I have made the required changes and the env is also ready. I haven't deployed any contracts yet.

I ran the npm run build. So, it has updated deployments.md, and I can see deployments/Sokol.

It has generated new constants in the dist folder too. Please let me know if I need to make any changes there.

@kaushalrajbacancy kaushalrajbacancy requested review from 0xSulpiride and vignesha22 and removed request for vignesha22 April 17, 2023 09:12
@linear
Copy link
Copy Markdown

linear bot commented Apr 17, 2023

PRO-1059 Decommission Sokol and add support for a new Gnosis testnet

Decommission Sokol and add support for a new Gnosis testnet

@kaushalrajbacancy
Copy link
Copy Markdown
Contributor Author

kaushalrajbacancy commented Apr 17, 2023

@ch4r10t33r @marie-fourier @lbw33 @vignesha22 I have deployed the contract and successfully worked in one go. This has updated a few more files. Please review this.

@0xSulpiride
Copy link
Copy Markdown
Contributor

0xSulpiride commented Apr 17, 2023

I will add Chiado relayers to GatewayV2 and approve the pr

@kaushalrajbacancy
Copy link
Copy Markdown
Contributor Author

kaushalrajbacancy commented Apr 17, 2023

I will add Chiado relayers to GatewayV2 and approve the pr

@marie-fourier I will wait for the confirmation.

0xSulpiride
0xSulpiride approved these changes Apr 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@0xSulpiride 0xSulpiride left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry, we don't have any relayers there yet @kaushalrajbacancy
approved

@kaushalrajbacancy kaushalrajbacancy merged commit 1060249 into master Apr 18, 2023
@kaushalrajbacancy kaushalrajbacancy deleted the feature/pro-1059-decommission-sokol-and-add-support-for-a branch April 18, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@vignesha22 vignesha22 Awaiting requested review from vignesha22

@arddluma arddluma Awaiting requested review from arddluma

@cryptonoyaiba cryptonoyaiba Awaiting requested review from cryptonoyaiba

+1 more reviewer

@0xSulpiride 0xSulpiride 0xSulpiride approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaushalrajbacancy @0xSulpiride @ch4r10t33r @cryptonoyaiba