fix: burn down ShellCheck baseline in core CLI (#8)#13
Merged
Conversation
Follow-up to #6. Fix the ShellCheck findings baselined in #6 for real and remove every `# shellcheck disable=` directive. - easy: SC2046/SC2086 quoting (command subs, $EASY_*_DIR args, $DATE); SC2155 (split `export EASY_DIR=$(...)`); SC2164 (`cd "$D" || return`); SC1001 (`grep '"version":'`); SC1090 (`# shellcheck source=/dev/null`) - commands/proxy.sh: SC2086 quoting; SC2155 (split `local X=$(...)`); SC2046 (quote `id=$(...)`); SC2124 (`"$*"` instead of `"${@}"`); SC2181 (`if CONTAINER_ID=$(docker run ...)` instead of a `$?` check) - configure-local-devenv: SC2155 (split `export EASY_HOME=$(pwd)`) - easyhome/add_domain, add_subdomain_http, add_subdomain_https: SC2086 `npm run lint` exits 0 with no baseline directives remaining; the #7 bats suite still passes 16/16. Closes #8 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6. When ShellCheck was introduced, the core CLI had ~60 pre-existing findings; #6 fixed only the real errors and baselined the rest with file-level
# shellcheck disable=directives. This PR burns down that baseline — fixing the findings for real and removing every directive.Done after #7 landed, so the bats suite is a safety net for the
easy/proxy.shdispatcher changes.Changes
easy$EASY_*_DIRargs,$DATE), SC2155 (splitexport EASY_DIR=$(...)), SC2164 (cd "$D" || return 1— was a latent bug), SC1001 (grep '"version":'), SC1090 (# shellcheck source=/dev/null)commands/proxy.shlocal X=$(...)), SC2046 (quoteid=$(...)), SC2124 ("$*"instead of"${@}"), SC2181 (if CONTAINER_ID=$(docker run ...)instead of an indirect$?check)configure-local-devenvexport EASY_HOME=$(pwd))easyhome/add_domain·add_subdomain_http·add_subdomain_https$1/$2/$3)No
# shellcheck disable=baseline directives remain.Test plan
The pre-push hook (lint + bats) passed on push —
git pushnow works without--no-verify.Closes #8
🤖 Generated with Claude Code