Refactor asset publishing and add header/footer web component export#20
Merged
Refactor asset publishing and add header/footer web component export#20
Conversation
rather than a custom output format
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the asset publishing mechanism by replacing a single publish-all-media.html partial with a modular system and adds web component exports for header/footer elements.
Key changes:
- Replaces monolithic media publishing with modular partials for different asset types
- Adds automatic generation of JavaScript web components for header and footer elements
- Updates CSS filename from
_global.scsstoglobal.scss
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| layouts/partials/publish.html | New orchestrator partial that calls all publishing modules |
| layouts/partials/publish-scss.html | Handles SCSS compilation and publishing |
| layouts/partials/publish-media.html | Simplified media asset publishing |
| layouts/partials/publish-all-media.html | Removed old monolithic media publishing partial |
| layouts/partials/ethmarks-components-js.html | New partial generating web components from header/footer |
| layouts/_default/baseof.html | Updated to use new publishing system and CSS filename |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| {{ range resources.Match "css/*.scss" }} | ||
| {{ $css := . | toCSS }} | ||
| {{ $cssMin := $css | minify }} | ||
| {{ $css.Publish }} |
There was a problem hiding this comment.
[nitpick] Both the original and minified CSS files are being published, which could lead to confusion about which version to use. Consider publishing only the minified version for production or add comments explaining why both are needed.
Suggested change
| {{ $css.Publish }} | |
| {{/* $css.Publish */}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.