Skip to content

add overflow detection to ethmarks-footer component#25

Merged
ethmarks merged 1 commit intomainfrom
ethmarks-footer-overflow
Oct 4, 2025
Merged

add overflow detection to ethmarks-footer component#25
ethmarks merged 1 commit intomainfrom
ethmarks-footer-overflow

Conversation

@ethmarks
Copy link
Copy Markdown
Owner

@ethmarks ethmarks commented Oct 4, 2025

Add a script to ethmarks-footer that handles height overflow.

Old New
Screenshot 2025-10-04 at 15-27-39 Components Test Screenshot 2025-10-04 at 15-27-13 Components Test

@ethmarks ethmarks requested a review from Copilot October 4, 2025 19:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds overflow detection functionality to the ethmarks-footer component to handle cases where page content exceeds the viewport height. The implementation detects when content overflows and applies appropriate CSS classes to enable responsive styling.

  • Added height overflow detection logic that compares content height to viewport height
  • Implemented ResizeObserver to monitor dynamic content changes
  • Applied conditional CSS class management for overflow states

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread layouts/partials/ethmarks-components-js.html
Comment thread layouts/partials/ethmarks-components-js.html
Comment thread layouts/partials/ethmarks-components-js.html
@ethmarks ethmarks merged commit 43a3f41 into main Oct 4, 2025
@ethmarks ethmarks deleted the ethmarks-footer-overflow branch October 4, 2025 19:36
ethmarks added a commit to ethmarks/blips that referenced this pull request Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants