Skip to content

[codex] fix security alerts#183

Open
parithosh wants to merge 1 commit into
masterfrom
codex/fix-security-alerts
Open

[codex] fix security alerts#183
parithosh wants to merge 1 commit into
masterfrom
codex/fix-security-alerts

Conversation

@parithosh
Copy link
Copy Markdown
Member

Summary

Fixes the open Dependabot and code scanning alert families by updating the frontend dependency graph and hardening the GitHub Actions workflows.

Dependency changes:

  • Refreshes web-ui/package-lock.json to patched versions for the alerted npm packages, including axios, DOMPurify, minimatch, lodash, fast-uri, serialize-javascript, yaml, postcss, and webpack-dev-server transitive paths.
  • Updates direct frontend ranges for the packages anchoring those fixes: swagger-ui-react, yaml, postcss, webpack-dev-server, copy-webpack-plugin, and css-minimizer-webpack-plugin.
  • Renames the library tree helper module to avoid the libraryTree.ts / LibraryTree.tsx case-resolution collision that broke local TypeScript checks on case-insensitive filesystems.

Workflow changes:

  • Removes caller-controlled ref inputs from reusable check/build workflows so reusable jobs checkout the event SHA instead of arbitrary PR-provided refs.
  • Moves the PR build workflow from pull_request_target to pull_request and adds explicit read-only default permissions.
  • Splits PR binary builds from Docker publishing so fork PRs do not receive DockerHub secrets, while same-repository/manual trusted Docker publishing remains available.
  • Adds explicit workflow permissions and switches internal artifact handoffs to artifact IDs to avoid artifact-name poisoning.

Validation

  • actionlint -shellcheck=
  • npm audit --json reports 0 vulnerabilities
  • npm run lint
  • npm run typecheck
  • npm run build (passes with existing webpack asset-size warnings)
  • go test ./...

@pk910 pk910 marked this pull request as ready for review May 20, 2026 10:58
barnabasbusa pushed a commit to ethpandaops/buildoor that referenced this pull request May 21, 2026
Mirrors the workflow hardening from ethpandaops/assertoor#183:
- Drop caller-controlled ref inputs from reusable check/build workflows
- Move PR build trigger from pull_request_target to pull_request
- Add explicit read-only default permissions to workflows
- Split fork-PR binary builds from Docker publishing so secrets never reach untrusted code
- Switch internal artifact handoffs to artifact IDs to avoid name poisoning

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pull Bot pushed a commit to Siriusmene/eth-beacon-genesis that referenced this pull request May 21, 2026
Mirrors the workflow hardening from ethpandaops/assertoor#183 and patches
three open Go dependabot alerts in the same PR.

Workflow changes:
- Drop caller-controlled ref inputs from reusable check/build workflows
- Move PR build trigger from pull_request_target to pull_request
- Add explicit read-only default permissions to workflows
- Split fork-PR binary builds from Docker publishing so secrets never reach untrusted code
- Switch internal artifact handoffs to artifact IDs to avoid name poisoning

Dependency updates:
- go.opentelemetry.io/otel v1.40.0 -> v1.43.0 (baggage header DoS)
- golang.org/x/crypto v0.44.0 -> v0.51.0 (ssh agent OOB read; ssh unbounded memory)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant