feat: add reusable GitHub Actions composite action for running benchmarks#71
Merged
Conversation
Mount host /proc/sys/vm/drop_caches into the container and add SYS_ADMIN capability so benchmarkoor can drop page/dentry/inode caches between tests. This brings the action in line with docker-compose.yaml.
The cpufreq package writes to /sys/devices/system/cpu/ to control CPU frequency, governors, and turbo boost during benchmarks. Docker mounts /sys read-only, so CPU frequency control fails inside containers. Add a configurable `global.cpu_sysfs_path` setting (following the existing `drop_caches_path` pattern) so the host's sysfs CPU directory can be bind-mounted at a different path inside the container. - Thread a basePath parameter through all sysfs functions in cpufreq - Add CPUSysfsPath field to GlobalConfig with GetCPUSysfsPath() getter - Add /sys/devices/system/cpu:/host_sys_cpu volume mount to docker-compose.yaml and action.yaml - Update config examples and documentation
Add 18 missing scalar config keys so Viper recognizes BENCHMARKOOR_* env var overrides for client settings, resource limits, retry new payloads syncing state, bootstrap FCU, and global paths.
Use BENCHMARKOOR_* environment variables instead of a temporary override YAML file to set container paths, now that all keys are registered in bindEnvKeys().
Pass BENCHMARKOOR_BENCHMARK_RESULTS_OWNER with the runner's UID:GID so result files created inside the Docker container are owned by the runner user, preventing permission denied errors during cleanup.
When paths contain multiple new segments (e.g. test names with `/`), os.MkdirAll creates intermediate directories that were not chowned, leaving them root-owned and preventing cleanup by the runner user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.