feat: git clone commits and docker data dirs to work with zfs/overlayfs#77
Merged
Conversation
git clone --branch only accepts branch/tag names, not commit hashes, causing fresh clones to fail in Docker where no repo cache exists. Detect commit hashes and use git init + fetch + checkout instead.
Parse config files with yq to extract datadir source_dir values, resolve each to its filesystem mountpoint via stat --format=%m, deduplicate, and add --mount flags with bind-propagation=rshared to the docker run command. This allows ZFS clones and overlayfs mounts to propagate between the benchmarkoor container and sibling client containers. Also changes /tmp mount to use rshared propagation and upgrades --cap-add=SYS_ADMIN to --privileged for ZFS/overlayfs support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.