otelcol: drop unparseable container logs quietly + filter nil container.name#15
Merged
Conversation
…er.name The filelog 'container' operator hits add_metadata_from_filepath failures during container churn and logs them at error. Those errors then re-enter the pipeline via filelog tailing otelcol's own stderr, multiplying volume ~10x per failure (stack traces). Adds on_error: drop_quiet to silence and drop the failed entry; updates the exclude filter to also drop entries with nil container.name as a safety net.
🤖 qu0b-reviewerSummaryTwo changes to the Issues
Suggestions
Reviewed @ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filelog 'container' operator hits add_metadata_from_filepath failures during container churn and logs them at error level. otelcol then tails its own stderr via filelog and re-ships those errors, ~10x amplification per failure (stack traces).
on_error: drop_quietsilences and drops the failed entry; updated filter expr drops entries with nil container.name as a safety net. Was ~18% of blob-devnet-0 log volume.