fix(dispatcher): prevent run ID mismatches when multiple groups share a workflow#20
Merged
fix(dispatcher): prevent run ID mismatches when multiple groups share a workflow#20
Conversation
… a workflow When multiple groups dispatch the same workflow, findWorkflowRun could assign the same GitHub run to multiple jobs or pick the wrong run. - Add buildClaimedRunIDs helper to track already-assigned run IDs - Skip claimed runs in findWorkflowRun to prevent double-assignment - Select oldest unclaimed run instead of newest (serialized dispatches mean the oldest unclaimed run is the correct match) - Acquire per-workflow lock in trackJob during run ID discovery to prevent races with the dispatch path
skylenet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple groups dispatch the same workflow, findWorkflowRun could assign the same GitHub run to multiple jobs or pick the wrong run.