feat(docker): make reverse proxy optional with ENABLE_PROXY flag #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the web container now puts the API_URL directly in config.json, allowing the browser to connect directly to the API. Set ENABLE_PROXY=true to use the previous behavior where nginx proxies /api/* requests to the backend. Changes: - Add ENABLE_PROXY env var (default: false) - Generate config.json with full API_URL in direct mode - Generate config.json with /api/v1 in proxy mode - Use dynamic DNS resolver for nginx upstream resolution - Fix config.json file permissions (644) for nginx access - Update docker-compose.yaml to use ENABLE_PROXY=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ENABLE_PROXY=trueto use nginx as a reverse proxy (previous behavior)Changes
ENABLE_PROXYenvironment variable (default:false)config.jsoncontains the fullAPI_URLconfig.jsoncontains/api/v1(relative path)/etc/resolv.conffor nginxconfig.jsonfile permissions (644) so nginx can read itdocker-compose.yamlto setENABLE_PROXY=trueUsage
Direct mode (default):
docker run -e API_URL=https://api.example.com dispatchoor-web # config.json: {"apiUrl": "https://api.example.com/api/v1"}Reverse proxy mode:
docker run -e API_URL=http://api:9090 -e ENABLE_PROXY=true dispatchoor-web # config.json: {"apiUrl": "/api/v1"}Test plan
make docker-build-webconfig.jsoncontains full API URLconfig.jsoncontains/api/v1config.jsonis accessible (not 403)