Fix nil pointer panic in deposits page#603
Merged
barnabasbusa merged 1 commit intomasterfrom Mar 11, 2026
Merged
Conversation
GetValidatorByIndex can return nil even when the validator index is known (e.g. during sync). All three call sites in buildDepositsPageData dereferenced the result without a nil check, causing a panic on the /validators/deposits page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pk910
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing:
Summary
GetValidatorByIndexcan returnnileven when the validator index is known (e.g. during sync), but all three call sites inbuildDepositsPageDatadereferenced it without a nil check, causing a panic on/validators/deposits?v=transactions"Deposited"status (consistent with the existing fallback when the validator index isn't found)Test plan
/validators/deposits?v=transactionsduring initial sync when validator state may be incomplete🤖 Generated with Claude Code