Reduce DB query build overhead with shared helpers#634
Merged
pk910 merged 17 commits intoethpandaops:masterfrom Apr 14, 2026
Merged
Reduce DB query build overhead with shared helpers#634pk910 merged 17 commits intoethpandaops:masterfrom
pk910 merged 17 commits intoethpandaops:masterfrom
Conversation
336aa65 to
e2eef96
Compare
… and byte‑slice map keys.
e2eef96 to
8740b7d
Compare
Member
|
Heya @Sahil-4555 |
pk910
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces DB query build overhead by centralizing placeholder construction and fork‑ID filtering into shared helpers, then applying them across hot query paths. The changes remove repeated string building and temporary slice allocations in many
IN (...)filters and batch queries, while also speeding up byte‑slice map key generation for lookup maps. Benchmarks show the placeholder builder is about 4.4x faster (18,568 ns/op down to 4,169 ns/op) with much fewer allocations (131 to 37), and byte‑slice key conversion is about 1.7x faster (209 ns/op down to 121 ns/op). Overall, the query assembly paths are now leaner and faster, especially when filters include large ID lists.