feat: add gas_used field to compute actual gas consumption per opcode #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcm
approved these changes
Dec 18, 2025
mattevans
approved these changes
Dec 18, 2025
Add a new gas_used field that computes the actual gas consumed by each opcode using the difference between consecutive gas values at the same depth level. This provides accurate gas accounting that differs from the pre-calculated gas_cost in cases like: - CALL/CREATE opcodes (includes child execution gas) - Dynamic gas costs (memory expansion, cold/warm storage access) - Last opcodes in call contexts (keeps pre-calculated cost) The gas_cost field is preserved unchanged for backwards compatibility. Also fix transaction return value handling to convert "0x" (empty hex) to nil for proper nullable storage. New files: - gas_cost.go: ComputeGasUsed() depth-tracking algorithm - gas_cost_test.go: Comprehensive test coverage Schema migration required: ALTER TABLE structlog ADD COLUMN gas_used UInt64 AFTER gas_cost;
Savid
force-pushed
the
feature/compute-actual-gas-used
branch
from
7561c0a to
1b8c454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new gas_used field that computes the actual gas consumed by each opcode using the difference between consecutive gas values at the same depth level. This provides accurate gas accounting that differs from the pre-calculated gas_cost in cases like:
The gas_cost field is preserved unchanged for backwards compatibility.
New files:
Schema migration required:
ALTER TABLE structlog ADD COLUMN gas_used UInt64 AFTER gas_cost;