fix(timings): align metrics with backend SUCCESS/VALID-only durations#355
Merged
fix(timings): align metrics with backend SUCCESS/VALID-only durations#355
Conversation
Member
mattevans
commented
Dec 16, 2025
mattevans
commented
- Default sort ClientVersionBreakdown by medianDuration asc when observations are hidden to show fastest clients first
- Weight duration averages by success/valid counts instead of total observations to match backend SUCCESS/VALID-only durations
- Filter slot and client data to SUCCESS/VALID rows before computing averages and charts so metrics match the displayed table
- Round query start time to hour boundary to align with hourly aggregated data and ensure consistent results
- Default sort ClientVersionBreakdown by medianDuration asc when observations are hidden to show fastest clients first - Weight duration averages by success/valid counts instead of total observations to match backend SUCCESS/VALID-only durations - Filter slot and client data to SUCCESS/VALID rows before computing averages and charts so metrics match the displayed table - Round query start time to hour boundary to align with hourly aggregated data and ensure consistent results
samcm
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.