fix: write auth mode to init config and restart server after login#78
Merged
fix: write auth mode to init config and restart server after login#78
Conversation
panda init was not writing mode: "oidc" to the generated config, so resolveAuthTargetFromConfig defaulted to "oauth" and OIDC discovery hit the proxy instead of Dex. Additionally, panda auth login now restarts the server container if it is running so it picks up the new credentials immediately instead of spinning on stale tokens until the next manual restart.
ClickHouseClusterConfig.Name moved to the embedded BaseDatasourceConfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
panda initnow writesmode: "oidc"(or other non-default modes) to the generated config when discovered from the proxy's/auth/metadataendpoint. Previously the mode was omitted, causingresolveAuthTargetFromConfigto default to"oauth"and OIDC discovery to fail against the proxy URL instead of Dex.panda auth loginnow automatically restarts the server container (if running) after saving new credentials, so the server picks them up immediately instead of spinning on stale in-memory tokens.panda initauth flow now setsBrandingURLso the success page branding works during init.