fix: preserve embedding metadata through authorizer datasource filter#80
Merged
fix: preserve embedding metadata through authorizer datasource filter#80
Conversation
FilterDatasources was constructing a new DatasourcesResponse but only copying EthNodeAvailable — EmbeddingAvailable and EmbeddingModel were silently dropped. When the proxy has OIDC auth enabled, the server's discovery call hit the authorizer filter, embedding info vanished, and searchruntime.Build returned nil. The server started without search, and the first search request panicked on a nil ExampleIndex receiver. Also makes search runtime required at startup (server refuses to start without proxy embedding) and simplifies the builder accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilterDatasourceswas building a newDatasourcesResponsebut only copyingEthNodeAvailable—EmbeddingAvailableandEmbeddingModelgot silently dropped. With OIDC auth on the proxy, the server's discovery call went through the filter, lost embedding info, andsearchruntime.Buildreturned nil. Server started without search and panicked on the first search request (nilExampleIndexreceiver). This preserves embedding metadata through the filter and makes search runtime required at startup so the server fails fast instead of running degraded.