Merged
Conversation
- Extract auditor to its own file (was in rate_limiter.go) - Reposition auditor in middleware chain after auth but before authorizer/rate-limiter so 403s and 429s are captured - Add remote_addr, query_string, request_bytes fields - Change duration from human-readable string to duration_ms (int64) - Remove unused AuditEntry struct and AuditorConfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the proxy auditor into its own file and adds
remote_addr,query_string(captures SQL/PromQL/LogQL),request_bytes, andduration_ms(replaces the human-readable duration string) fields. Moves the auditor middleware to sit after authentication but before the authorizer and rate limiter, so authorization denials (403) and rate-limited requests (429) are now captured in audit logs.