fix: derive cache_dir from base_dir so embedding cache survives restarts#88
Merged
fix: derive cache_dir from base_dir so embedding cache survives restarts#88
Conversation
Users with configs generated before cache_dir was added to the init template defaulted to ~/.panda/data/cache inside the container — an ephemeral path not on the persistent panda-cache volume. Every container recreate lost the cache, re-embedding 8k+ EIP chunks on every startup. Derive cache_dir as a sibling of base_dir instead, and add /data/cache to the Dockerfile and entrypoint chown logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derives
cache_diras a sibling ofbase_dirinstead of hardcoding~/.panda/data/cache. Adds/data/cacheto Dockerfiles and entrypoint chown logic so the embedding vector cache persists across container restarts.