avoid local block hash calculation for compatibility with future forks#142
Merged
avoid local block hash calculation for compatibility with future forks#142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid getting stuck with invalid block hashes when activating future forks (eg. gloas):
Root cause for this issue is the Block.Hash() method implemented by go-ethereum, which assumes a fully known block header to generate a local hash on. This is unfortunately not the case for future forks which may introduce new fields to the block header that are not known to spamoor or the used go-ethereum version.
This PR avoids using the Hash() method, using the precalculated hash that is part of the RPC response.