Metric collection compatibility enhancement#1621
Merged
Merged
Conversation
- Increased default polling rate to 15s - Set price-check poll rates to 5m - Allow override of job name and polling interval via Docker labels
aliask
force-pushed
the
monitoring-compatibility
branch
from
e59aa23 to
0249704
Compare
Contributor
Author
|
I've added a few new features:
I'm not so sure about that last one - the other features should make the configuration extensible enough for 99% of users. |
aliask
force-pushed
the
monitoring-compatibility
branch
from
281ec0f to
3f9d0fc
Compare
Service has been killed off since end of Sept '23
aliask
force-pushed
the
monitoring-compatibility
branch
from
3f9d0fc to
835f088
Compare
Remove scrape jobs for node_exporter and cadvisor - they aren't running Add scrape job for json-exporter, it's monitored normally Don't provision dashboards that rely on missing providers
yorickdowne
requested changes
Nov 18, 2023
yorickdowne
approved these changes
Nov 25, 2023
Collaborator
|
Works well here, both my global external labels as well as the remote write are preserved. Merging. Thank you! |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 eth-docker Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change overview
Explanation
Eth-docker currently does not set the polling configs, so it uses the default values (1 minute interval).
Several publicly shared Grafana dashboards expect Prometheus metrics to be available at a higher rate than what
eth-dockerprovides, so importing these dashboards into Grafana causes some widgets to display "No Data".These values were taken from the Rocketpool config, but the official lighthouse-metrics config also uses 15s, and geth even suggests 10s.
I've also added some extra config overrides to set the job name and poll interval via Docker labels. If these labels are omitted it still defaults to the compose service name.
In my case, this was done for compatibility with the Rocketpool dashboard as they name their jobs differently service name, but there may be other situations where this would be helpful.
I know that the polling settings can be overriden via a
custom-prom.ymlfile, however the job name and individual container interval settings cannot (as far as I understand).The increased polling rate will give users higher resolution metrics as a bonus, and the additional load on resources should not be significant.