Add docker-compose version check#796
Merged
Merged
Conversation
Collaborator
|
I like it. It'll fail on macOS though. Could you take a look at the You know what ... let me merge this and then make the macOS change myself. Thanks for this! |
|
Woohoo, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 eth-docker Contributor: Head on over to GitPOAP.io and connect your GitHub account to mint! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating my Goerli node, I found that things stopped working, and I got unexpected errors about unsupported configuration items in
prysm-base.yml.I did some investigation and it appears that the
profilesoption which was introduced in 0e2447a means that at leastdocker-composeversion 1.28.0 is needed and mine was too old - Ubuntu version from default apt is 1.25.0.This PR adds a simple version check to
determine_compose(), similar to the Ubuntu version test.