Skip to content

Fix ./test/L2/L2Genesis.t.sol test #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qzhodl merged 3 commits into from
Dec 5, 2024
Merged

Fix ./test/L2/L2Genesis.t.sol test #98

qzhodl merged 3 commits into from
Dec 5, 2024

Conversation

@qzhodl
Copy link

@qzhodl qzhodl commented Nov 28, 2024

Issue:
The command forge test --match-path test/L2/L2Genesis.t.sol failed because SoulGasToken was not considered.

Solution:

  • Include SoulGasToken in the test.
  • PREDEPLOY_COUNT is changed to 4096

blockchaindevsh
blockchaindevsh reviewed Nov 29, 2024
View reviewed changes
This was referenced Nov 30, 2024
Closed
Closed
@qzhodl qzhodl merged commit dd08ac6 into op-es Dec 5, 2024
1 check passed
@qzhodl qzhodl deleted the l2-genesis-test branch December 5, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qizhou qizhou qizhou approved these changes

@blockchaindevsh blockchaindevsh blockchaindevsh approved these changes

@dajuguan dajuguan Awaiting requested review from dajuguan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qzhodl @qizhou @blockchaindevsh