Conversation
ethteck
approved these changes
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation for the
reloc_addrs.txtformat.I also changed
create_configto create a basicsymbol_addrs.txtandreloc_addrs.txtfrom the information it is already gathering.The generated
symbol_addrs.txtfile just names theentrypointand themainsymbols.Example for the generated file:
The
reloc_addrs.txtfile contains relocs for the bss symbols referenced by the entrypoint.It also contains a commented out entry for the stack, it is commented out because we can't infer the actual start of that symbol with just the info on the entrypoint, instead I left a comment explaining this.
Example for the generated file:
closes #465