Allow bss_size for bss subsegments#541
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to run splat on a very outdated project and got an error here, because splat can't figure out the size for this bss section.
splat tries to calculate the vram address for a segment by subtracting its vram to the vram of the next segment.
In this case, the next segment doesn't have a vram address, so splat choked with an assert.
With this PR it is possible to specify a bss_size for this specific bss subsegment, getting rid of the issue.
This should be used as a last resort tho, because this attribute can get outdated pretty quickly when doing more file splits, so I added a check to ensure is not possible to use this if the size can actually be inferred.