Conversation
These apparently are caused by the browser's idle timeout for background scripts, which is enforced more strictly in Manifest v3. There is no manifest option to make the background script persistent, and using a keepalive logic is fallible because the browser will restrict JS execution time for idle pages. The solution is to automatically reconnect the contentscript<->background connection on disconnect, and reseting all the appropriate callbacks.
There was a problem hiding this comment.
Pull Request Overview
This PR adds automatic reconnection logic between the content script and background script to address intermittent disconnects under Manifest v3 idle timeouts.
- Removed an obsolete debug log in the inpage script.
- Refactored the content script to use a recursive
connectToBackgroundfunction that cleans up and re-establishes streams on disconnect. - Added a console log in the background script when setting up provider connections.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/inpage/index.ts | Removed a leftover debug statement logging the provider object. |
| src/content-script/index.ts | Introduced connectToBackground for reconnect logic and updated comments. |
| src/background/index.ts | Added a console.log for when setupProviderConnection is invoked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a longstanding bug where browser tabs would ocasionaly get disconnected from the background script, and weirdly would require not one but two or more refreshes to fix.
These apparently are caused by the browser's idle timeout for background scripts, which is enforced more strictly in Manifest v3. There is no manifest option to make the background script persistent, and using a keepalive logic is fallible because the browser will restrict JS execution time for idle pages.
The solution is to automatically reconnect the
contentscript<->background connection on disconnect, and reseting all the appropriate callbacks.