Skip to content

Allow for Fides-specific and Privacy-Center-specific Resources#68

Merged
RobertKeyser merged 4 commits intomainfrom
rk-resources
Aug 28, 2023
Merged

Allow for Fides-specific and Privacy-Center-specific Resources#68
RobertKeyser merged 4 commits intomainfrom
rk-resources

Conversation

@RobertKeyser
Copy link
Copy Markdown
Contributor

@RobertKeyser RobertKeyser commented Aug 28, 2023

Description of Changes

This PR moves the resources value into two separate values: one for fides/workers and one for the privacy centers.

NOTE: this change requires modification to how the resources in the values.yaml are specified. If you set the resources value, be sure to update them to fides.resources and privacyCenter.resources.

Pre-merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Increment Applicable Chart Versions
  • Relevant Follow-Up Issues Created
  • Update the Fides chart CHANGELOG.md
  • Update the Fides-minimal chart CHANGELOG.md

@RobertKeyser RobertKeyser requested a review from a team as a code owner August 28, 2023 15:27
@github-actions github-actions bot added the helm/fides The Fides Helm Chart label Aug 28, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 28, 2023
@RobertKeyser RobertKeyser self-assigned this Aug 28, 2023
Copy link
Copy Markdown

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, but flagging that the lack of backwards compat could be an option. Do you think it will be?

@RobertKeyser RobertKeyser merged commit f821ab8 into main Aug 28, 2023
@RobertKeyser RobertKeyser deleted the rk-resources branch August 28, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation helm/fides The Fides Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants