Allow for Fides-specific and Privacy-Center-specific Resources#68
Merged
RobertKeyser merged 4 commits intomainfrom Aug 28, 2023
Merged
Allow for Fides-specific and Privacy-Center-specific Resources#68RobertKeyser merged 4 commits intomainfrom
RobertKeyser merged 4 commits intomainfrom
Conversation
NevilleS
approved these changes
Aug 28, 2023
NevilleS
left a comment
There was a problem hiding this comment.
This seems reasonable, but flagging that the lack of backwards compat could be an option. Do you think it will be?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR moves the resources value into two separate values: one for fides/workers and one for the privacy centers.
NOTE: this change requires modification to how the resources in the values.yaml are specified. If you set the
resourcesvalue, be sure to update them tofides.resourcesandprivacyCenter.resources.Pre-merge Checklist
Relevant Follow-Up Issues CreatedUpdate the Fides-minimal chart CHANGELOG.md