Skip to content

2129-Side nav disappears when viewing request details#2155

Merged
chriscalhoun1974 merged 2 commits into
mainfrom
2129-side-nav-disappears-when-viewing-request-details
Jan 6, 2023
Merged

2129-Side nav disappears when viewing request details#2155
chriscalhoun1974 merged 2 commits into
mainfrom
2129-side-nav-disappears-when-viewing-request-details

Conversation

@chriscalhoun1974
Copy link
Copy Markdown
Contributor

@chriscalhoun1974 chriscalhoun1974 commented Jan 6, 2023 •
edited
Loading

Closes #2129

Code Changes

  • Executed npm audit fix
  • Created /privacy-requests/[id] route
  • Ensured side nav is displayed when viewing privacy request details
  • Refactored subject-request folder files to privacy-requests folder now

Steps to Confirm

  1. Execute nox -s test_env
  2. Open browser tab to http://localhost:3000 (Fides)
  3. Login with fidestest account
  4. Click the Review privacy requests card
  5. Open another browser tab to http://localhost:3001 (Privacy Center)
  6. Click Access your data card
  7. Enter Name, Email, and Phone values and click the Continue button
  8. On the Fides tab, refresh your page. New DSR record should be displayed.
  9. Click the View Details menu option for the given DSR record
  10. Verify the Privacy requests side nav is displayed to the left of the DSR record details

Pre-Merge Checklist

Screen Shot

Screen Shot 2023-01-06 at 11 56 36 AM

@chriscalhoun1974
2129-Side nav disappears when viewing request details
4e639a9 
1. Executed npm audit fix
2. Created /privacy-requests/[id] route
3. Ensured side nav is displayed when viewing privacy request details
@chriscalhoun1974 chriscalhoun1974 marked this pull request as draft January 6, 2023 16:46
LKCSmith
LKCSmith approved these changes Jan 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@LKCSmith LKCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate these changes Refactored subject-request folder files to privacy-requests folder now and it looks good to me! Thanks 👍

@chriscalhoun1974 chriscalhoun1974 marked this pull request as ready for review January 6, 2023 20:00
@chriscalhoun1974 chriscalhoun1974 added Fides NUX Improvements UI Work related to UI bug Something isn't working labels Jan 6, 2023
@chriscalhoun1974 chriscalhoun1974 merged commit 25c80bb into main Jan 6, 2023
@chriscalhoun1974 chriscalhoun1974 deleted the 2129-side-nav-disappears-when-viewing-request-details branch January 6, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssangervasi ssangervasi Awaiting requested review from ssangervasi

@Kelsey-Ethyca Kelsey-Ethyca Awaiting requested review from Kelsey-Ethyca

1 more reviewer

@LKCSmith LKCSmith LKCSmith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working Fides NUX Improvements UI Work related to UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Side nav disappears when viewing request details

2 participants

@chriscalhoun1974 @LKCSmith