Merged
Conversation
Passing run #3020 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
allisonking
suggested changes
Jun 29, 2023
Contributor
allisonking
left a comment
There was a problem hiding this comment.
this turned out to be pretty complicated for a toast, didn't it? 😄 nice job tackling it, just a few suggestions, and one bigger thing that might need to be rolled out into its own ticket
...nts/admin-ui/src/features/datastore-connections/system_portal_config/TestConnectionToast.tsx
Outdated
Show resolved
Hide resolved
...nts/admin-ui/src/features/datastore-connections/system_portal_config/TestConnectionToast.tsx
Outdated
Show resolved
Hide resolved
...min-ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParameters.tsx
Outdated
Show resolved
Hide resolved
...ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx
Show resolved
Hide resolved
...ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx
Show resolved
Hide resolved
allisonking
approved these changes
Jun 30, 2023
Contributor
allisonking
left a comment
There was a problem hiding this comment.
nice job turning this around!! left a very nit comment. other than that, can you make a follow up issue out of this bug we talked about? you can add it to the roadmap team project, and also assign it to the next sprint (doesn't mean it'll get worked on next sprint, but gives product a chance to see the ticket and decide its priority!)
...ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3601
Description Of Changes
Removed test connection box below "Test connection" button and replaced it with success or failure toasts, depending on result of test.
Success example:
Failure example:
Code Changes
TestConnectioncomponent to be a standalone component for the toastHandleTestConnectionClickmethod inConnectorParametersFormto prevent the method from being run repeatedly; errors are now handled by toasting in theConnectorParametersaboveSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md