remove transitions from banner on FidesJS tests#5976
Merged
gilluminate merged 4 commits intomainfrom Apr 10, 2025
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
gilluminate
force-pushed
the
gill/speed-up-fidesjs-tests
branch
from
3e19f56 to
51d0ac7
Compare
lucanovera
approved these changes
Apr 8, 2025
Contributor
lucanovera
left a comment
lucanovera
left a comment
There was a problem hiding this comment.
👏 👏 👏 great work in this pr! it improves the tests runtime, the reliability of the tests and you also cleaned up the code. Approved!
gilluminate
force-pushed
the
gill/speed-up-fidesjs-tests
branch
from
51d0ac7 to
6c47447
Compare
gilluminate
force-pushed
the
gill/speed-up-fidesjs-tests
branch
from
6c47447 to
692fbdc
Compare
gilluminate
force-pushed
the
gill/speed-up-fidesjs-tests
branch
from
692fbdc to
36cc9a8
Compare
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 52s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Each time the banner loads in Cypress tests for FidesJS, it takes a full second before the tests can properly run while it waits for the animation to run. Removing the CSS transition can shave a couple minutes off the total Cypress run time.
Code Changes