Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
| import GoogleCloudStorageConfiguration from "./GoogleCloudStorageConfiguration"; | ||
| import S3StorageConfiguration from "./S3StorageConfiguration"; | ||
|
|
||
| const StorageConfiguration = () => { |
There was a problem hiding this comment.
I think the ConfigurePrivacyRequestsStorage page (which uses this component) is not currently accessible by the user
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6006 +/- ##
==========================================
+ Coverage 86.86% 86.90% +0.03%
==========================================
Files 418 419 +1
Lines 25916 25995 +79
Branches 2826 2829 +3
==========================================
+ Hits 22513 22591 +78
Misses 2785 2785
- Partials 618 619 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JadeCara
left a comment
There was a problem hiding this comment.
This is an exciting piece of functionality! Thanks for adding so many tests! I have a couple change requests around testing, but mostly looks really good!
One thing I am trying to get better at myself, is making sure I Autospec on mocks. I called it out specifically on a few tests where a class is getting mocked, but its also great for functions.
- Signature enforcement: Your mock will only accept the same arguments as the real function.
- Early error detection: If you call the mock with the wrong arguments, the test fails.
- Cleaner, safer mocks: It prevents unexpected behavior due to missing or extra arguments.
JadeCara
left a comment
There was a problem hiding this comment.
Looks good! Great work!
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 51s |
| Commit |
|
| Committer | Victoria Cruces |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
Closes HA-524
Description Of Changes
Google Cloud Storage (GCS) can now be chosen as storage for privacy requests.
Code Changes
Steps to Confirm
/api/v1/storage/defaultwith the following body:/api/v1/configwith the following body:/api/v1/storage/default/{storage_type}/secretwith storage_type "gcp" and the body of the request is in 1password under the name "GCS prj-sandbox-55855-test-bucket".To test that the storage is working:
FIDES__SECURITY__SUBJECT_REQUEST_DOWNLOAD_UI_ENABLEDmust be true to be able to download the files.Another way to configure storage and its secrets:
/privacy-requests/configure/storage, select GCS and fill out the form. The secret details are in 1password under the name "GCS prj-sandbox-55855-test-bucket".Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works