Admin UI: Define Specific Publisher Restrictions#6013
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
722f6da to
b2cb8ca
Compare
f42f421 to
fc2b1d7
Compare
jpople
left a comment
There was a problem hiding this comment.
Changes overall look good-- nitpicky, but in a few spots some text needs to be appropriately sentence-cased.
I think the "Vendor IDs" input has some issues though:
- I don't think "Enter a single ID or range of IDs and press enter" is the most helpful as a placeholder-- it's unclear to me that that means I can enter multiple single IDs or ranges, and also that the ranges are meant to be in exactly the format
"##-##". I would prefer something like:
Enter IDs or ranges (e.g. "1-10") and press enter
- I think validation/feedback is also a bit lacking-- if I put something invalid, the backend just throws an error but it might be hard to know from this exactly what I did wrong. It'd be helpful to have at least an error status on the field and a generic error message in this case, if not something more specific.
- I'm also getting a seemingly-incorrect error message in one case; if I add a "restrict specific vendors" restriction and then try to add an "allow specific vendors", I get the overlap error message and can't submit even when none of the entered IDs overlap with the restricted ones.
| )} | ||
| <Button | ||
| size="small" | ||
| onClick={() => handleSelection(currentSelection)} |
There was a problem hiding this comment.
In testing it felt like some feedback would be nice here-- a toast, or maybe even fake a loading state for a moment?
|
@jpople "Allow" is the exact opposite of "Restrict." So to allow something is to restrict everything else. That's why the ranges behave that way, any Allow along-side a restrict must be a value within the restrict ranges when it's set on another restriction type. Hope that helps. |
|
@jpople There's a bug in my FE validation that's letting it get through and then the BE is catching it. I'll address that bug. |
This reverts commit fc2b1d7.
9c03d5f to
45ee9bd
Compare
|
@jpople Thanks for the feedback. I've updated the titles with sentence-case, updated the Vendor IDs field with better instructions/restrictions, as well as fixing the Allow list validations to match the Backend validation. Ready for another review. |
45ee9bd to
16eb569
Compare
jpople
left a comment
There was a problem hiding this comment.
Thanks for the changes, tested locally and everything's looking good to me.
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 50s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |



Closes LJ-593
Description Of Changes
This PR introduces comprehensive TCF configuration management features to the admin UI consent settings page. The changes focus on implementing publisher restrictions, purpose restrictions, and TCF configuration management capabilities. Legacy publisher restrictions are still supported if those are already enabled, giving the user the option to remove those and start over with the new options (see this loom https://www.loom.com/share/903d538e0323444f9766f9742be82962?sid=57b3c17e-1b77-45e9-afe9-9185357deab3) for an example.
Code Changes
Added new TCF configuration management components:
TCFConfigurationDropdownfor selecting and deleting TCF configsCreateTCFConfigModalfor creating new TCF configurationsPublisherRestrictionsConfigand related tables for managing restrictionsTCFOverrideToggleas a shared component between legacy and new UXImplemented publisher restrictions functionality:
Added state management and API integration:
Steps to Confirm
Enable TCF and configure a TCF experience
Test TCF configurations from the main consent setting screen:
2. Navigate to the consent settings page in the Admin UI (
/settings/consent)3. If consent configs already exist, you should still see the old table (see https://www.loom.com/share/903d538e0323444f9766f9742be82962?sid=57b3c17e-1b77-45e9-afe9-9185357deab3). Otherwise you'll be given the option to enable overrides and to create a new config.
4. Verify ability to create, select, and delete TCF configurations from the main screen.
Test creating and managing publisher restrictions for one or more of the flexible purposes:
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works