Skip to content

Remove cypress-parallel from Cypress CI run#6034

Merged
nrxsmith merged 1 commit intomainfrom
remove-cypress-parallel
Apr 10, 2025
Merged

Remove cypress-parallel from Cypress CI run#6034
nrxsmith merged 1 commit intomainfrom
remove-cypress-parallel

Conversation

@nrxsmith
Copy link
Copy Markdown
Contributor

@nrxsmith nrxsmith commented Apr 10, 2025

Description Of Changes

The Privacy Center Cypress Tests were being a little flakey with cypress-parallel, so this goes back to using the regular cypress command. I left in the library and the command in the package.json as some may find it useful to run locally. It does quite well for that use case.

Code Changes

Removed the custom command from the github workflow

Steps to Confirm

Running the Privacy Center Cypress workflow should show the normal cypress run command being used, not cy:parallel.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 8:17pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Apr 10, 2025 8:17pm

@nrxsmith nrxsmith merged commit a76df4a into main Apr 10, 2025
18 checks passed
@nrxsmith nrxsmith deleted the remove-cypress-parallel branch April 10, 2025 20:28
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 10, 2025

fides    Run #12809

Run Properties:  status check passed Passed #12809  •  git commit a76df4a6b7: Remove cypress-parallel from Cypress CI run (#6034)
Project fides
Branch Review main
Run status status check passed Passed #12809
Run duration 00m 53s
Commit git commit a76df4a6b7: Remove cypress-parallel from Cypress CI run (#6034)
Committer Nate Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.86%. Comparing base (342940b) to head (644c53d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6034   +/-   ##
=======================================
  Coverage   86.86%   86.86%           
=======================================
  Files         418      418           
  Lines       25915    25915           
  Branches     2826     2826           
=======================================
  Hits        22512    22512           
  Misses       2785     2785           
  Partials      618      618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants