Skip to content

LJ-680 - Fixed two Georgia's in regions list and incorrect name for the state SD#6036

Merged
vcruces merged 2 commits intomainfrom
LJ-680
Apr 11, 2025
Merged

LJ-680 - Fixed two Georgia's in regions list and incorrect name for the state SD#6036
vcruces merged 2 commits intomainfrom
LJ-680

Conversation

@vcruces
Copy link
Copy Markdown
Contributor

@vcruces vcruces commented Apr 11, 2025

Closes LJ-680

Description Of Changes

  • In the list of regions there are two regions named Georgia, one corresponds to the country and the other to the US state. This was confusing for the users in the UI because they couldn't distinguish between them. The country text was changed to "Georgia (Country)".

  • The text corresponding to the state SD was incorrect. It said "San Diego" when it should have read "South Dakota".

Code Changes

  • Updated texts for regions with errors.

Steps to Confirm

  1. In the left menu, go to Consent -> Experiences
  2. Scroll down to Locations & Languages
  3. Click "Add location"
  4. Search for Georgia
  5. Search for South Dakota

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 2:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2025 2:09pm

Copy link
Copy Markdown
Contributor

@RobertKeyser RobertKeyser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@vcruces vcruces merged commit 603156f into main Apr 11, 2025
17 checks passed
@vcruces vcruces deleted the LJ-680 branch April 11, 2025 14:58
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 11, 2025

fides    Run #12810

Run Properties:  status check passed Passed #12810  •  git commit 603156fd2f: LJ-680 - Fixed two Georgia's in regions list and incorrect name for the state SD...
Project fides
Branch Review main
Run status status check passed Passed #12810
Run duration 00m 51s
Commit git commit 603156fd2f: LJ-680 - Fixed two Georgia's in regions list and incorrect name for the state SD...
Committer Victoria Cruces
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants