Skip to content

HA-570 - Integrations manage modals now are cappable of showing a small description#6037

Merged
andres-torres-marroquin merged 7 commits intomainfrom
andres/HA-570
Apr 14, 2025
Merged

HA-570 - Integrations manage modals now are cappable of showing a small description#6037
andres-torres-marroquin merged 7 commits intomainfrom
andres/HA-570

Conversation

@andres-torres-marroquin
Copy link
Copy Markdown
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Apr 11, 2025

Closes HA-570

Description Of Changes

Integrations manage modals now are cappable of showing a small description

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 9:52pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 9:52pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.86%. Comparing base (1716101) to head (02ce674).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6037   +/-   ##
=======================================
  Coverage   86.86%   86.86%           
=======================================
  Files         418      418           
  Lines       25916    25916           
  Branches     2826     2826           
=======================================
  Hits        22513    22513           
  Misses       2785     2785           
  Partials      618      618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can we update so the description also shows in the "create new" form instead of only in the "manage" form once you've already clicked in?

Screenshot 2025-04-14 at 12 59 24

@andres-torres-marroquin
Copy link
Copy Markdown
Contributor Author

Looks good, but can we update so the description also shows in the "create new" form instead of only in the "manage" form once you've already clicked in?

Screenshot 2025-04-14 at 12 59 24

Ahh that's a good one, I'll add it, thank you

Copy link
Copy Markdown
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, ship it!

@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 14, 2025

fides    Run #12817

Run Properties:  status check passed Passed #12817  •  git commit 9a25aed723: HA-570 - Integrations manage modals now are cappable of showing a small descript...
Project fides
Branch Review main
Run status status check passed Passed #12817
Run duration 00m 51s
Commit git commit 9a25aed723: HA-570 - Integrations manage modals now are cappable of showing a small descript...
Committer Andrés Torres Marroquín
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants