Skip to content

HA-545 - Do not generate keys when creating a Website Monitor#6041

Merged
andres-torres-marroquin merged 2 commits intomainfrom
andres/HA-545
Apr 14, 2025
Merged

HA-545 - Do not generate keys when creating a Website Monitor#6041
andres-torres-marroquin merged 2 commits intomainfrom
andres/HA-545

Conversation

@andres-torres-marroquin
Copy link
Copy Markdown
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Apr 14, 2025

Closes HA-545

Description Of Changes

Do not generate keys when creating a Website Monitor

Code Changes

  • Removed generation of key when creating a Website Monitor.

Steps to Confirm

  1. Create a website monitor, verify that it is not sending key to the API endpoint.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 5:20pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2025 5:20pm

@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 14, 2025

fides    Run #12814

Run Properties:  status check passed Passed #12814  •  git commit 1279ec248c: HA-545 - Do not generate keys when creating a Website Monitor (#6041)
Project fides
Branch Review main
Run status status check passed Passed #12814
Run duration 00m 51s
Commit git commit 1279ec248c: HA-545 - Do not generate keys when creating a Website Monitor (#6041)
Committer Andrés Torres Marroquín
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants