Skip to content

Update bulk ignore assets toast#6043

Merged
jpople merged 5 commits intomainfrom
jpople/ha-519/uncategorized-assets-toast
Apr 17, 2025
Merged

Update bulk ignore assets toast#6043
jpople merged 5 commits intomainfrom
jpople/ha-519/uncategorized-assets-toast

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Apr 14, 2025

Closes HA-519

Description Of Changes

Updates toast description on bulk ignoring uncategorized assets in the action center.

Screenshot 2025-04-14 at 13 43 16

Steps to Confirm

  1. Populate some web monitor results and view them in the action center
  2. View "Uncategorized assets"
  3. Select some assets using the checkbox, then in "Actions", click "Ignore"
  4. Should see toast message above
  5. Do the same under a named system table
  6. Should see toast message with system name

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 2:32pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 2:32pm

@jpople jpople merged commit 2deac7b into main Apr 17, 2025
17 checks passed
@jpople jpople deleted the jpople/ha-519/uncategorized-assets-toast branch April 17, 2025 15:02
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 17, 2025

fides    Run #12829

Run Properties:  status check passed Passed #12829  •  git commit 2deac7b161: Update bulk ignore assets toast (#6043)
Project fides
Branch Review main
Run status status check passed Passed #12829
Run duration 00m 52s
Commit git commit 2deac7b161: Update bulk ignore assets toast (#6043)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants