Skip to content

Allow all data uses for system assets#6049

Merged
jpople merged 10 commits intomainfrom
jpople/ha-610/allow-all-data-uses-for-assets
Apr 17, 2025
Merged

Allow all data uses for system assets#6049
jpople merged 10 commits intomainfrom
jpople/ha-610/allow-all-data-uses-for-assets

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Apr 15, 2025

Closes HA-610

Description Of Changes

Changes form and table in system "Assets" tab to handle all data uses instead of only consent categories.

Steps to Confirm

  1. Go to "Assets" tab from system form
  2. Edit an existing asset or click "Add asset"
  3. In the form, should see "Data uses" select that's populated with full data use list
  4. Pick one that isn't a consent category (e.g. "Collect")
  5. On saving, should see the non-consent-category data use you picked listed in the table
  6. In the table, click the + button in the "Data uses" column
  7. Similarly, should see all data uses listed, not just consent categories

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 3:10pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 3:10pm

Copy link
Copy Markdown
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both dropdowns worked well and were fully populated for me. Nice work.

@jpople jpople merged commit ba5d8cd into main Apr 17, 2025
17 checks passed
@jpople jpople deleted the jpople/ha-610/allow-all-data-uses-for-assets branch April 17, 2025 15:49
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 17, 2025

fides    Run #12830

Run Properties:  status check passed Passed #12830  •  git commit ba5d8cde16: Allow all data uses for system assets (#6049)
Project fides
Branch Review main
Run status status check passed Passed #12830
Run duration 00m 50s
Commit git commit ba5d8cde16: Allow all data uses for system assets (#6049)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants