Skip to content

Model changes for consent fixes#6054

Merged
galvana merged 8 commits intomainfrom
LJ-586-fides-changes-for-consent-fix
Apr 18, 2025
Merged

Model changes for consent fixes#6054
galvana merged 8 commits intomainfrom
LJ-586-fides-changes-for-consent-fix

Conversation

@galvana
Copy link
Copy Markdown
Contributor

@galvana galvana commented Apr 16, 2025

Closes LJ-586

Description Of Changes

Model changes to support the consent looping fix in Fidesplus

Code Changes

  • Updated ConsentWebhookResult schema
  • Updated the notice_preference_map returned from build_user_consent_and_filtered_preferences_for_service
  • Minor changes to the consent automation function signatures
  • Test updates

Steps to Confirm

  1. Follow the testing instructions at https://github.com/ethyca/fidesplus/pull/2065

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 8:01pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 8:01pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.88%. Comparing base (9bf708c) to head (a9bc91b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/api/service/connectors/saas_connector.py 75.00% 0 Missing and 1 partial ⚠️
...vice/saas_request/saas_request_override_factory.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6054   +/-   ##
=======================================
  Coverage   86.87%   86.88%           
=======================================
  Files         419      419           
  Lines       25983    25977    -6     
  Branches     2827     2827           
=======================================
- Hits        22574    22569    -5     
+ Misses       2789     2788    -1     
  Partials      620      620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@galvana galvana merged commit a519c45 into main Apr 18, 2025
17 checks passed
@galvana galvana deleted the LJ-586-fides-changes-for-consent-fix branch April 18, 2025 20:03
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 18, 2025

fides    Run #12837

Run Properties:  status check passed Passed #12837  •  git commit a519c45aaf: Model changes for consent fixes (#6054)
Project fides
Branch Review main
Run status status check passed Passed #12837
Run duration 00m 51s
Commit git commit a519c45aaf: Model changes for consent fixes (#6054)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants